Here’s another amusing method I recently found in some production code which comes straight from the “can’t be bothered to learn the framework (or how to Google)” style of programming:
/// <summary>
/// Converts a month number into the name
/// </summary>
/// <param name="monthNumber"></param>
private string GetMonthName(int monthNumber)
{
return String.Format("{0:MMMM}", new DateTime(1969, monthNumber, 1));
}
I wonder what the significance of 1969 is? Year of the author's birth, perhaps?!
Aside from being hacky, there is a performance implication to unnecessarily creating new DateTime objects and performing string formatting in this way. In my tests, I’ve found that this method is around 18 times slower than simply calling System.Globalization.DateTimeFormatInfo.CurrentInfo.GetMonthName(monthNumber).
